New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up typing_extensions
-- typing_extensions
#932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You (sensibly) removed a few non-underscored, but also not exported via __all__
attributes. As this is technically an API change (even though it's not exported via __all__
), could you add these removals to typing_extensions/CHANGELOG
:
TypingMeta
OLD_GENERICS
SUBS_TREE
HAVE_ANNOTATED
HAVE_PROTOCOLS
Also could you mention in the Changelog that starting with 4.0.0 support for Python 2 and <3.6 has been dropped?
A few more remarks below.
de58c57
to
5d75e5f
Compare
5d75e5f
to
12ec8de
Compare
Sorry, forgot to add a changelog entry earlier -- have now done so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. For future reference: Please don't force push as it makes it harder to review changes.
Sorry - I had to rebase onto |
Yes, we squash merge anyway, so rebasing should not be necessary. |
xref #892
@srittau
Actual
typing_extensions
PR. Unchanged from original.A